[X25]: Avoid divides and sparse warnings

2 messages, 2 authors, 2008-01-14 · open the first message on its own page

[X25]: Avoid divides and sparse warnings

From: Eric Dumazet <hidden>
Date: 2008-01-13 10:33:13

   CHECK   net/x25/af_x25.c
net/x25/af_x25.c:117:46: warning: expensive signed divide
   CHECK   net/x25/x25_facilities.c
net/x25/x25_facilities.c:209:30: warning: expensive signed divide
   CHECK   net/x25/x25_in.c
net/x25/x25_in.c:250:26: warning: expensive signed divide
   CHECK   net/x25/x25_proc.c
net/x25/x25_proc.c:48:11: warning: context imbalance in 'x25_seq_route_start' 
- wrong count at exit
net/x25/x25_proc.c:72:13: warning: context imbalance in 'x25_seq_route_stop' - 
unexpected unlock
net/x25/x25_proc.c:112:11: warning: context imbalance in 
'x25_seq_socket_start' - wrong count at exit
net/x25/x25_proc.c:129:13: warning: context imbalance in 'x25_seq_socket_stop' 
- unexpected unlock
net/x25/x25_proc.c:190:11: warning: context imbalance in 
'x25_seq_forward_start' - wrong count at exit
net/x25/x25_proc.c:215:13: warning: context imbalance in 
'x25_seq_forward_stop' - unexpected unlock
   CHECK   net/x25/x25_subr.c
net/x25/x25_subr.c:362:57: warning: expensive signed divide

Signed-off-by: Eric Dumazet <redacted>

  net/x25/af_x25.c         |    4 ++--
  net/x25/x25_facilities.c |    4 +---
  net/x25/x25_in.c         |    2 +-
  net/x25/x25_proc.c       |    6 ++++++
  net/x25/x25_subr.c       |    2 +-
  5 files changed, 11 insertions(+), 7 deletions(-)

Re: [X25]: Avoid divides and sparse warnings

From: David Miller <davem@davemloft.net>
Date: 2008-01-14 06:29:07

From: Eric Dumazet <redacted>
Date: Sun, 13 Jan 2008 11:33:01 +0100
   CHECK   net/x25/af_x25.c
net/x25/af_x25.c:117:46: warning: expensive signed divide
   CHECK   net/x25/x25_facilities.c
net/x25/x25_facilities.c:209:30: warning: expensive signed divide
   CHECK   net/x25/x25_in.c
net/x25/x25_in.c:250:26: warning: expensive signed divide
   CHECK   net/x25/x25_proc.c
net/x25/x25_proc.c:48:11: warning: context imbalance in 'x25_seq_route_start' 
- wrong count at exit
net/x25/x25_proc.c:72:13: warning: context imbalance in 'x25_seq_route_stop' - 
unexpected unlock
net/x25/x25_proc.c:112:11: warning: context imbalance in 
'x25_seq_socket_start' - wrong count at exit
net/x25/x25_proc.c:129:13: warning: context imbalance in 'x25_seq_socket_stop' 
- unexpected unlock
net/x25/x25_proc.c:190:11: warning: context imbalance in 
'x25_seq_forward_start' - wrong count at exit
net/x25/x25_proc.c:215:13: warning: context imbalance in 
'x25_seq_forward_stop' - unexpected unlock
   CHECK   net/x25/x25_subr.c
net/x25/x25_subr.c:362:57: warning: expensive signed divide

Signed-off-by: Eric Dumazet <redacted>
Applied, thanks Eric.

We might just want to make sk_rcvbuf et al. unsigned, it
crops up a lot and I can't see any valid reason for it
to be negative or for uses of it to matter with other
signed values.

Or did we discuss that to death already? :-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help