Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

On Mon, 14 Jan 2008 14:07:46 EST, Paul Moore said:

There have been quite a few changes in lblnet-2.6_testing since 2.6.24-rc6-mm1 
so I would recommend taking the whole tree.  I'm also not quite sure if

Weird.  I did a 'git clone git://git.infradead.org/users/pcmoore/lblnet-2.6_testing'
into a new directory this morning, and doing a 'git log' against that only
showed the one added commit:

commit 5d95575903fd3865b884952bd93c339d48725c33
Author: Paul Moore [off-list ref]
Date:   Wed Jan 9 15:30:23 2008 -0500

    SELinux: Add warning messages on network denial due to error
    
    Currently network traffic can be sliently dropped due to non-avc errors which
    can lead to much confusion when trying to debug the problem.  This patch adds
    warning messages so that when these events occur there is a user visible
    notification.
    
    Signed-off-by: Paul Moore [off-list ref]

commit 9259ca5fd8b9fbdd2c3edade593dead905d8391e
Author: Paul Moore [off-list ref]
Date:   Wed Jan 9 15:30:23 2008 -0500

    SELinux: Add network ingress and egress control permission checks
(already in 24-rc6-mm1).

Somebody please tell me it's my git-idiocy..

simply reverting the "Convert the netif code to use ifindex values" patch 
would solve the problem as there are other patches in the rc6-mm1 tree that 
rely on skb->iif being valid (new code, not converted code).

That would explain why I'm still seeing issues..

 If you want to 
stick with a _relatively_ vanilla rc6-mm1 tree I would leave everything in 
and simply apply the following patch which solved the skb_clone()/iif 
problem:

http://git.infradead.org/?p=users/pcmoore/lblnet-2.6_testing;a=commitdiff;h=02f1c89d6e36507476f78108a3dcc78538be460b

OK, I'll go look at that..

On Monday 14 January 2008 2:37:02 pm Valdis.Kletnieks@vt.edu wrote:

On Mon, 14 Jan 2008 14:07:46 EST, Paul Moore said:

quoted

There have been quite a few changes in lblnet-2.6_testing since
2.6.24-rc6-mm1 so I would recommend taking the whole tree.  I'm also not
quite sure if

Weird.  I did a 'git clone
git://git.infradead.org/users/pcmoore/lblnet-2.6_testing' into a new
directory this morning, and doing a 'git log' against that only showed the
one added commit:

commit 5d95575903fd3865b884952bd93c339d48725c33
Author: Paul Moore [off-list ref]
Date:   Wed Jan 9 15:30:23 2008 -0500

    SELinux: Add warning messages on network denial due to error

    Currently network traffic can be sliently dropped due to non-avc errors
which can lead to much confusion when trying to debug the problem.  This
patch adds warning messages so that when these events occur there is a user
visible notification.

    Signed-off-by: Paul Moore [off-list ref]

commit 9259ca5fd8b9fbdd2c3edade593dead905d8391e
Author: Paul Moore [off-list ref]
Date:   Wed Jan 9 15:30:23 2008 -0500

    SELinux: Add network ingress and egress control permission checks
(already in 24-rc6-mm1).

Somebody please tell me it's my git-idiocy..

It might be something on my end with managing the lblnet-2.6_testing git tree; 
I'm still pretty clueless when it comes to git.

I've got a git tree on my dev machine which is backed against Linus' tree and 
managed via stacked-git.  I update the patches in this tree, refresh them 
against new bits from Linus, etc and when something significant changes I 
update the git tree on infradead.org and post a new patchset to the related 
lists.  The process of updating the git tree on infradead.org usually 
involves deleting the entire tree located there, re-creating it, and then 
doing a git-push from my dev machine.  I have no idea if this is "correct" or 
not, but I've often wondered if this is a the "right" way to do it ...

-- 
paul moore
linux security @ hp