DORMANTno replies

[PATCH drivers/net/skfp/h/fplustm.h] parentheses around RX_FIFO_SPACE definition

From: Roel Kluin <hidden>
Date: 2007-12-17 21:55:20
Subsystem: networking drivers, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

drivers/net/skfp/h/fplustm.h:129:
#define RX_FIFO_SPACE           0x4000 - RX_FIFO_OFF

drivers/net/skfp/fplustm.c:1404:
                smc->hw.fp.fifo.rx1_fifo_size = RX_FIFO_SPACE *
                SMT_R1_RXD_COUNT/(SMT_R1_RXD_COUNT+SMT_R2_RXD_COUNT) ;
                smc->hw.fp.fifo.rx2_fifo_size = RX_FIFO_SPACE *
                SMT_R2_RXD_COUNT/(SMT_R1_RXD_COUNT+SMT_R2_RXD_COUNT) ;

Add parentheses to definition to prevent operator precedence errors

Signed-off-by: Roel Kluin <redacted>
---
diff --git a/drivers/net/skfp/h/fplustm.h b/drivers/net/skfp/h/fplustm.h
index 98bbf65..588579c 100644
--- a/drivers/net/skfp/h/fplustm.h
+++ b/drivers/net/skfp/h/fplustm.h
@@ -126,7 +126,7 @@ struct s_smt_rx_queue {
 #define	SYNC_TRAFFIC_ON		0x2
 
 /* big FIFO memory */
-#define	RX_FIFO_SPACE		0x4000 - RX_FIFO_OFF
+#define	RX_FIFO_SPACE		(0x4000 - RX_FIFO_OFF)
 #define	TX_FIFO_SPACE		0x4000
 
 #define	TX_SMALL_FIFO		0x0900
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help