[PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used

Subsystems: networking [general], the rest

STALE6820d

2 messages, 2 authors, 2007-12-12 · open the first message on its own page

[PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used

From: Denis V. Lunev <hidden>
Date: 2007-12-12 11:03:50

netns: network namespace was passed into dev_getbyhwaddr but not used

Signed-off-by: Denis V. Lunev <redacted>
diff --git a/net/core/dev.c b/net/core/dev.c
index 06615df..677f35b 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -675,7 +675,7 @@ struct net_device *dev_getbyhwaddr(struct net *net, unsigned short type, char *h
 
 	ASSERT_RTNL();
 
-	for_each_netdev(&init_net, dev)
+	for_each_netdev(net, dev)
 		if (dev->type == type &&
 		    !memcmp(dev->dev_addr, ha, dev->addr_len))
 			return dev;

Re: [PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used

From: David Miller <davem@davemloft.net>
Date: 2007-12-12 18:50:23

From: "Denis V. Lunev" <redacted>
Date: Wed, 12 Dec 2007 14:05:17 +0300
netns: network namespace was passed into dev_getbyhwaddr but not used

Signed-off-by: Denis V. Lunev <redacted>
Applied.

Please always put the subsystem name in the headline in
all capitals and surround it with brackets, like this:

[NETNS]: Blah blah blah.

Also treat the description line as a true English sentence, this means
capitalize the first word and put a period at the end of it.  This is
a changelog message for a professional piece of software, not some
"innanet" slang talk on some IRC channel. :-)

I make these edits to every one of your patch submissions and it's
getting tiring, I hoped you would notice this yourself before my
needing to tell you about it explicitly :-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help