Mark Lord [off-list ref] writes:
Arjan van de Ven wrote:
quoted
On Sat, 01 Dec 2007 15:21:12 -0500
Mark Lord [off-list ref] wrote:
quoted
Eric W. Biederman wrote:
quoted
Stephen Hemminger [off-list ref] writes:
Sure. We keep the updated dev_get_by_XXXX that takes a network
namespace parameter.
..
And what should code be passing in when "# CONFIG_NET_NS is not set" ?
network drivers probably really really don't want to call
dev_get_by_XXX...
..
Fine. But all of them want to call sk_alloc(),
network drivers should be calling sk_alloc less then they should
call dev_get_by_XXXX. Only protocols call sk_alloc.
and many want to do register_netdev().
I haven't even touched register_netdev.
So what should they be using there ?
What are you having problems with?
It is hard to answer specific questions without a context.
Eric
On 12/02/2007 12:13 AM, Eric W. Biederman wrote:
Mark Lord [off-list ref] writes:
quoted
Fine. But all of them want to call sk_alloc(),
network drivers should be calling sk_alloc less then they should
call dev_get_by_XXXX. Only protocols call sk_alloc.
quoted
and many want to do register_netdev().
I haven't even touched register_netdev.
quoted
So what should they be using there ?
What are you having problems with?
It is hard to answer specific questions without a context.
VMware vmnet.
Eric W. Biederman wrote:
Mark Lord [off-list ref] writes:
quoted
Arjan van de Ven wrote:
quoted
On Sat, 01 Dec 2007 15:21:12 -0500
Mark Lord [off-list ref] wrote:
quoted
Eric W. Biederman wrote:
quoted
Stephen Hemminger [off-list ref] writes:
Sure. We keep the updated dev_get_by_XXXX that takes a network
namespace parameter.
..
And what should code be passing in when "# CONFIG_NET_NS is not set" ?
network drivers probably really really don't want to call
dev_get_by_XXX...
..
Fine. But all of them want to call sk_alloc(),
network drivers should be calling sk_alloc less then they should
call dev_get_by_XXXX. Only protocols call sk_alloc.
..
I think I saw some bridge code that calls it, too.
Regardless, it's EXPORT_SYMBOL(), but now unusable
due to the GPL-only symbol "init_net".
Meanwhile, you are avoiding answering the question:
quoted
quoted
quoted
And what should code be passing in when "# CONFIG_NET_NS is not set" ?
..
quoted
and many want to do register_netdev().
I haven't even touched register_netdev.
..
Bull-pucky. Somebody did:
quoted hunk
@@ -3361,6 +3595,8 @@ int register_netdevice(struct net_device *dev)
/* When net_device's are persistent, this will be fatal. */
BUG_ON(dev->reg_state != NETREG_UNINITIALIZED);
+ BUG_ON(!dev->nd_net);
+ net = dev->nd_net;
spin_lock_init(&dev->queue_lock);
spin_lock_init(&dev->_xmit_lock);
..
That new BUG_ON() line complains if nd_net has not been initialized,
and the only thing I see drivers putting there is GPL-only "&init_net".
quoted
So what should they be using there ?
What are you having problems with?
..
Avoiding the question again there, too.
I personally am not having problems with anything.
But I noticed the API change, and would like somebody to fix it.
Any of the three ways (or a fourth, if you've got one) might do.
Cheers