Re: [PATCHv7 1/5] Remove unnecessary locks from rtnetlink (in do_setlink)
From: Jarek Poplawski <hidden>
Date: 2007-11-30 22:11:36
From: Jarek Poplawski <hidden>
Date: 2007-11-30 22:11:36
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
The do_setlink function is protected by rtnl, additional locks are unnecessary, and the set_operstate() function is called from protected parts. Locks removed from both functions.
It doesn't look like in accordance with a comment to dev_base_lock in dev.c. And it makes eg. rfc2863_policy() locking from link_watch.c looking strange. Isn't there needed some additional comment to this? Regards, Jarek P.