[PATCH] ucc_geth: fix compilation

Subsystems: networking drivers, the rest

STALE6906d

5 messages, 4 authors, 2007-09-18 · open the first message on its own page

[PATCH] ucc_geth: fix compilation

From: Anton Vorontsov <hidden>
Date: 2007-09-13 15:20:36

Currently qe_bd_t is used in the macro call -- dma_unmap_single,
which is a no-op on PPC32, thus error is hidden today. Starting
with 2.6.24, macro will be replaced by the empty static function,
and erroneous use of qe_bd_t will trigger compilation error.

Signed-off-by: Anton Vorontsov <redacted>
---

Reposting this to include netdev in Cc.

 drivers/net/ucc_geth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
index 12e01b2..9a38dfe 100644
--- a/drivers/net/ucc_geth.c
+++ b/drivers/net/ucc_geth.c

@@ -2148,7 +2148,7 @@ static void ucc_geth_memclean(struct ucc_geth_private *ugeth)
 		for (j = 0; j < ugeth->ug_info->bdRingLenTx[i]; j++) {
 			if (ugeth->tx_skbuff[i][j]) {
 				dma_unmap_single(NULL,
-						 ((qe_bd_t *)bd)->buf,
+						 ((struct qe_bd *)bd)->buf,
 						 (in_be32((u32 *)bd) &
 						  BD_LENGTH_MASK),
 						 DMA_TO_DEVICE);

-- 
1.5.0.6

Re: [PATCH] ucc_geth: fix compilation

From: Kumar Gala <hidden>
Date: 2007-09-14 14:04:43

On Sep 13, 2007, at 10:23 AM, Anton Vorontsov wrote:

Currently qe_bd_t is used in the macro call -- dma_unmap_single,
which is a no-op on PPC32, thus error is hidden today. Starting
with 2.6.24, macro will be replaced by the empty static function,
and erroneous use of qe_bd_t will trigger compilation error.

Signed-off-by: Anton Vorontsov <redacted>
---

Jeff, I'm going to pick this up via the powerpc.git tree since its  
currently only broken in our for-2.6.24 branch (because of other  
changes in there).  Any issues?

- k

quoted hunk

Reposting this to include netdev in Cc.

 drivers/net/ucc_geth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
index 12e01b2..9a38dfe 100644
--- a/drivers/net/ucc_geth.c
+++ b/drivers/net/ucc_geth.c

@@ -2148,7 +2148,7 @@ static void ucc_geth_memclean(struct

ucc_geth_private *ugeth)
 		for (j = 0; j < ugeth->ug_info->bdRingLenTx[i]; j++) {
 			if (ugeth->tx_skbuff[i][j]) {
 				dma_unmap_single(NULL,
-						 ((qe_bd_t *)bd)->buf,
+						 ((struct qe_bd *)bd)->buf,
 						 (in_be32((u32 *)bd) &
 						  BD_LENGTH_MASK),
 						 DMA_TO_DEVICE);
-- 
1.5.0.6
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ucc_geth: fix compilation

From: Jeff Garzik <hidden>
Date: 2007-09-15 23:32:27

Anton Vorontsov wrote:

Currently qe_bd_t is used in the macro call -- dma_unmap_single,
which is a no-op on PPC32, thus error is hidden today. Starting
with 2.6.24, macro will be replaced by the empty static function,
and erroneous use of qe_bd_t will trigger compilation error.

Signed-off-by: Anton Vorontsov <redacted>
---

Reposting this to include netdev in Cc.

 drivers/net/ucc_geth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applied

RE: [PATCH] ucc_geth: fix compilation

From: Li Yang-r58472 <hidden>
Date: 2007-09-18 08:56:28

-----Original Message-----
From: linuxppc-dev-bounces+leoli=freescale.com@ozlabs.org 
[mailto:linuxppc-dev-bounces+leoli=freescale.com@ozlabs.org] 
On Behalf Of Kumar Gala
Sent: Friday, September 14, 2007 10:08 PM
To: Jeff Garzik
Cc: linuxppc-dev@ozlabs.org list; netdev
Subject: Re: [PATCH] ucc_geth: fix compilation


On Sep 13, 2007, at 10:23 AM, Anton Vorontsov wrote:

quoted

Currently qe_bd_t is used in the macro call --

dma_unmap_single, which

quoted

is a no-op on PPC32, thus error is hidden today. Starting

with 2.6.24,

quoted

macro will be replaced by the empty static function, and

erroneous use

quoted

of qe_bd_t will trigger compilation error.

Signed-off-by: Anton Vorontsov <redacted>
---

Jeff, I'm going to pick this up via the powerpc.git tree 
since its currently only broken in our for-2.6.24 branch 
(because of other changes in there).  Any issues?

Kumar,

Kim Phillips has posted the same patch to netdev list before Anton.
Therefore, I do prefer to use his.  Thanks

- Leo

Re: [PATCH] ucc_geth: fix compilation

From: Kumar Gala <hidden>
Date: 2007-09-18 14:02:06

On Sep 18, 2007, at 3:56 AM, Li Yang-r58472 wrote:

quoted

-----Original Message-----
From: linuxppc-dev-bounces+leoli=freescale.com@ozlabs.org
[mailto:linuxppc-dev-bounces+leoli=freescale.com@ozlabs.org]
On Behalf Of Kumar Gala
Sent: Friday, September 14, 2007 10:08 PM
To: Jeff Garzik
Cc: linuxppc-dev@ozlabs.org list; netdev
Subject: Re: [PATCH] ucc_geth: fix compilation


On Sep 13, 2007, at 10:23 AM, Anton Vorontsov wrote:

quoted

Currently qe_bd_t is used in the macro call --

dma_unmap_single, which

quoted

is a no-op on PPC32, thus error is hidden today. Starting

with 2.6.24,

quoted

macro will be replaced by the empty static function, and

erroneous use

quoted

of qe_bd_t will trigger compilation error.

Signed-off-by: Anton Vorontsov <redacted>
---

Jeff, I'm going to pick this up via the powerpc.git tree
since its currently only broken in our for-2.6.24 branch
(because of other changes in there).  Any issues?

Kumar,

Kim Phillips has posted the same patch to netdev list before Anton.
Therefore, I do prefer to use his.  Thanks

No problem.  Jeff seems to have picked up some version of the fix.

- k

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help