On the day of Thursday 23 August 2007 Greg KH hast written:
On Wed, Aug 22, 2007 at 10:42:25PM +0200, Willy Tarreau wrote:
quoted
On Wed, Aug 22, 2007 at 08:15:03PM +0200, Prakash Punnoor wrote:
quoted
Hi,
even if Greg is waiting for some special invitation
(http://lkml.org/lkml/2007/8/14/229), I suggest putting this patch by
Ayaz on top:
http://lkml.org/lkml/2007/8/10/296
That's what I prepare first, but then noticed it's not in mainline.
quoted
Perhaps Ayaz wants to give Greg the clarification he needs... :sigh:
He should, as the fix is not in mainline either :-(
I don't think Greg asks for specific clarification, just a plain patch
with a short commit log on its own which does not include remains of
older mails.
Exactly, that is what I am waiting for.
And also I need the change to go into mainline first, as we can not
diverge with the -stable releases.
Can we get that into mainline then? I haven't seen forcedeth in MAINTAINERS,
so I added netdev to the cc list.
bye,
--
(°= =°)
//\ Prakash Punnoor /\\
V_/ \_V
On Thu, Aug 23, 2007 at 05:50:41PM +0200, Prakash Punnoor wrote:
On the day of Thursday 23 August 2007 Greg KH hast written:
quoted
On Wed, Aug 22, 2007 at 10:42:25PM +0200, Willy Tarreau wrote:
quoted
On Wed, Aug 22, 2007 at 08:15:03PM +0200, Prakash Punnoor wrote:
quoted
Hi,
even if Greg is waiting for some special invitation
(http://lkml.org/lkml/2007/8/14/229), I suggest putting this patch by
Ayaz on top:
http://lkml.org/lkml/2007/8/10/296
That's what I prepare first, but then noticed it's not in mainline.
quoted
Perhaps Ayaz wants to give Greg the clarification he needs... :sigh:
He should, as the fix is not in mainline either :-(
I don't think Greg asks for specific clarification, just a plain patch
with a short commit log on its own which does not include remains of
older mails.
Exactly, that is what I am waiting for.
And also I need the change to go into mainline first, as we can not
diverge with the -stable releases.
Can we get that into mainline then? I haven't seen forcedeth in MAINTAINERS,
so I added netdev to the cc list.
It might help if someone sends a real patch that can be applied :)
thanks,
greg k-h
Hi Greg,
On Thu, Aug 23, 2007 at 09:55:13AM -0700, Greg KH wrote:
It might help if someone sends a real patch that can be applied :)
This is getting really silly now :-) We're all wasting more time
wondering who will send the patch than posting it. I've lost, I got
fed up first, so here it is. Please apply to mainline then stable.
Thanks,
Willy
--
From a0e2922b99eedd9863232368ea2afe072c52783e Mon Sep 17 00:00:00 2001
From: Willy Tarreau <w@1wt.eu>
Date: Thu, 23 Aug 2007 21:35:41 +0200
Subject: [PATCH] fix realtek phy id in forcedeth
As noticed by Chuck Ebbert, commit c5e3ae8823693b260ce1f217adca8add1bc0b3de
introduced a copy-paste typo, as realtek phy is 0x732 and not 0x1c1. Obvious
fix below suggested by Ayaz Abdulla.
Signed-off-by: Willy Tarreau <w@1wt.eu>
Cc: Ayaz Abdulla <redacted>
Cc: Chuck Ebbert <redacted>
---
drivers/net/forcedeth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index 10f4e3b..1938d6d 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -552,7 +552,7 @@ union ring_type {
#define PHY_OUI_MARVELL 0x5043
#define PHY_OUI_CICADA 0x03f1
#define PHY_OUI_VITESSE 0x01c1
-#define PHY_OUI_REALTEK 0x01c1
+#define PHY_OUI_REALTEK 0x0732
#define PHYID1_OUI_MASK 0x03ff
#define PHYID1_OUI_SHFT 6
#define PHYID2_OUI_MASK 0xfc00--
1.5.2.5
Willy Tarreau wrote:
Hi Greg,
On Thu, Aug 23, 2007 at 09:55:13AM -0700, Greg KH wrote:
quoted
It might help if someone sends a real patch that can be applied :)
This is getting really silly now :-) We're all wasting more time
wondering who will send the patch than posting it. I've lost, I got
fed up first, so here it is. Please apply to mainline then stable.
Thanks,
Willy
--
quoted
From a0e2922b99eedd9863232368ea2afe072c52783e Mon Sep 17 00:00:00 2001
From: Willy Tarreau <w@1wt.eu>
Date: Thu, 23 Aug 2007 21:35:41 +0200
Subject: [PATCH] fix realtek phy id in forcedeth
As noticed by Chuck Ebbert, commit c5e3ae8823693b260ce1f217adca8add1bc0b3de
introduced a copy-paste typo, as realtek phy is 0x732 and not 0x1c1. Obvious
fix below suggested by Ayaz Abdulla.
Signed-off-by: Willy Tarreau <w@1wt.eu>
Cc: Ayaz Abdulla <redacted>
Cc: Chuck Ebbert <redacted>
---
drivers/net/forcedeth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
applied