Re: [2/2] 2.6.23-rc2: known regressions with patches

On Sun, 2007-08-05 at 18:26 +0200, Michal Piotrowski wrote:

Hi all,

Modpost

Subject         : modpost bug breaks ia64 cross compilation
References      : http://lkml.org/lkml/2007/7/27/30
                  http://lkml.org/lkml/2007/7/27/418
Last known good : ?
Submitter       : Jan Dittmer [off-list ref]
Caused-By       : Thomas Renninger [off-list ref]
                  commit 29b71a1ca74491fab9fed09e9d835d840d042690
Handled-By      : ?
Patch           : http://lkml.org/lkml/2007/8/2/211
Status          : patch was suggested

A patch was sent to Tony. AFAIK it got accepted, not sure whether it
already is in any and which git tree...

Networking

Subject         : tg3 dead after s2ram
References      : http://lkml.org/lkml/2007/7/31/121
Last known good : ?
Submitter       : Joachim Deguara [off-list ref]
Caused-By       : ?
Handled-By      : Michael Chan [off-list ref]
Patch           : http://lkml.org/lkml/2007/8/2/288
Status          : patch available

David Miller sent a message that it got applied.

Thanks,

   Thomas

quoted

Caused-By       : Thomas Renninger [off-list ref]
                  commit 29b71a1ca74491fab9fed09e9d835d840d042690

A patch was sent to Tony. AFAIK it got accepted, not sure whether it
already is in any and which git tree...

The suggested patch adds manual padding to the acpi_device_id structure
definition in include/linux/mod_devicetable.h  I didn't take it, and it
appears that nobody else did either.  It is not in Linus' tree (as of 2.6.23-rc2).

I expressed doubts about whether this is the right fix.  The problem
is that when cross-compiling a locally compiled utility makes a size &
alignment check.  This is bogus.  We shouldn't care whether this structure
compiles to the same size/alignment as the kernel that will use on the
target platform.

Is fixing this the right way (make the scripts/mod/file2alias.c understand
target alignment rules in a cross environment) just too hideous to
contemplate ... and we should just sacrifice 7 bytes of padding in
order to keep life simple?

-Tony