[2.6 patch] make pktgen.c:get_ipsec_sa() static and non-inline

STALE6957d

2 messages, 2 authors, 2007-07-31 · open the first message on its own page

[2.6 patch] make pktgen.c:get_ipsec_sa() static and non-inline

From: Adrian Bunk <hidden>
Date: 2007-07-29 15:07:03

Non-static inline code usually doesn't makes sense.

In this case making is static and non-inline is the correct solution.

Signed-off-by: Adrian Bunk <redacted>

---
--- linux-2.6.23-rc1-mm1/net/core/pktgen.c.old	2007-07-26 20:12:01.000000000 +0200
+++ linux-2.6.23-rc1-mm1/net/core/pktgen.c	2007-07-26 20:12:13.000000000 +0200
@@ -2156,8 +2156,7 @@
 /* If there was already an IPSEC SA, we keep it as is, else
  * we go look for it ...
 */
-inline
-void get_ipsec_sa(struct pktgen_dev *pkt_dev, int flow)
+static void get_ipsec_sa(struct pktgen_dev *pkt_dev, int flow)
 {
 	struct xfrm_state *x = pkt_dev->flows[flow].x;
 	if (!x) {

Re: [2.6 patch] make pktgen.c:get_ipsec_sa() static and non-inline

From: David Miller <davem@davemloft.net>
Date: 2007-07-31 01:04:38

From: Adrian Bunk <redacted>
Date: Sun, 29 Jul 2007 16:58:40 +0200
Non-static inline code usually doesn't makes sense.

In this case making is static and non-inline is the correct solution.

Signed-off-by: Adrian Bunk <redacted>
Applied, thanks Adrian.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help