[PATCH] NET_CLS_RSVP6 should depend on IPV6

Subsystems: networking [general], tc subsystem, the rest

STALE6974d

4 messages, 3 authors, 2007-07-14 · open the first message on its own page

[PATCH] NET_CLS_RSVP6 should depend on IPV6

From: Gabriel C <hidden>
Date: 2007-07-14 10:39:27

Hello,

cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends
on IPV6.


Signed-off-by: Gabriel Craciunescu <redacted>

---

net/sched/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/sched/Kconfig b/net/sched/Kconfig
index b466288..200976e 100644
--- a/net/sched/Kconfig
+++ b/net/sched/Kconfig
@@ -299,6 +299,7 @@ config NET_CLS_RSVP
 
 config NET_CLS_RSVP6
        tristate "IPv6 Resource Reservation Protocol (RSVP6)"
+       depends on IPV6
        select NET_CLS
        ---help---
          The Resource Reservation Protocol (RSVP) permits end systems to
@@ -306,7 +307,7 @@ config NET_CLS_RSVP6
          is important for real time data such as streaming sound or video.
 
          Say Y here if you want to be able to classify outgoing packets
based
-         on their RSVP requests and you are using the IPv6.
+         on their RSVP requests and you are using the IPv6 protocol.
 
          To compile this code as a module, choose M here: the
          module will be called cls_rsvp6.

Re: [PATCH] NET_CLS_RSVP6 should depend on IPV6

From: Patrick McHardy <hidden>
Date: 2007-07-14 15:37:13

Gabriel C wrote:
cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends
on IPV6.

I can't see any functional dependency on IPv6, what exactly are you
refering to? People might want to use it on a bridge for example
without having IPv6 running locally.

Re: [PATCH] NET_CLS_RSVP6 should depend on IPV6

From: Gabriel C <hidden>
Date: 2007-07-14 18:30:26

Patrick McHardy wrote:
Gabriel C wrote:
  
quoted
cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends
on IPV6.
    

I can't see any functional dependency on IPv6, what exactly are you
refering to? People might want to use it on a bridge for example
without having IPv6 running locally.

  
I didn't knew it can be used with bridges , in this case just ignore the
patch and sorry for the noise.


Regards,

Gabriel

Re: [PATCH] NET_CLS_RSVP6 should depend on IPV6

From: David Miller <davem@davemloft.net>
Date: 2007-07-14 20:04:44

From: Patrick McHardy <redacted>
Date: Sat, 14 Jul 2007 17:36:14 +0200
Gabriel C wrote:
quoted
cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends
on IPV6.

I can't see any functional dependency on IPv6, what exactly are you
refering to? People might want to use it on a bridge for example
without having IPv6 running locally.
That's my feeling as well.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help