[patch 5/7] use is_power_of_2() in cxgb3/cxgb3_main.c
From: akpm@linux-foundation.org
Date: 2007-07-09 18:50:57
From: vignesh babu <redacted> Replace (n & (n-1)) with is_power_of_2() Signed-off-by: vignesh babu <redacted> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- drivers/net/cxgb3/cxgb3_main.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff -puN drivers/net/cxgb3/cxgb3_main.c~use-is_power_of_2-in-cxgb3-cxgb3_mainc drivers/net/cxgb3/cxgb3_main.c
--- a/drivers/net/cxgb3/cxgb3_main.c~use-is_power_of_2-in-cxgb3-cxgb3_mainc
+++ a/drivers/net/cxgb3/cxgb3_main.c@@ -43,6 +43,7 @@ #include <linux/proc_fs.h> #include <linux/rtnetlink.h> #include <linux/firmware.h> +#include <linux/log2.h> #include <asm/uaccess.h> #include "common.h"
@@ -1818,8 +1819,8 @@ static int cxgb_extension_ioctl(struct n return -EBUSY; if (copy_from_user(&m, useraddr, sizeof(m))) return -EFAULT; - if (!m.rx_pg_sz || (m.rx_pg_sz & (m.rx_pg_sz - 1)) || - !m.tx_pg_sz || (m.tx_pg_sz & (m.tx_pg_sz - 1))) + if (!is_power_of_2(m.rx_pg_sz) || + !is_power_of_2(m.tx_pg_sz)) return -EINVAL; /* not power of 2 */ if (!(m.rx_pg_sz & 0x14000)) return -EINVAL; /* not 16KB or 64KB */
_