[PATCH] NET: [CORE] Re-enable irqs before pushing pending DMA requests

Subsystems: networking [general], the rest

STALE6980d

2 messages, 2 authors, 2007-06-24 · open the first message on its own page

[PATCH] NET: [CORE] Re-enable irqs before pushing pending DMA requests

From: Shannon Nelson <hidden>
Date: 2007-06-21 16:35:07

This moves the local_irq_enable() call in net_rx_action() to before
calling the CONFIG_NET_DMA's dma_async_memcpy_issue_pending() rather
than after.  This shortens the irq disabled window and allows for DMA
drivers that need to do their own irq hold.

Signed-off-by: Shannon Nelson <redacted>
---

 net/core/dev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 2609062..ee051bb 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2009,6 +2009,7 @@ static void net_rx_action(struct softirq_action *h)
 		}
 	}
 out:
+	local_irq_enable();
 #ifdef CONFIG_NET_DMA
 	/*
 	 * There may not be any more sk_buffs coming right now, so push
@@ -2022,7 +2023,6 @@ out:
 		rcu_read_unlock();
 	}
 #endif
-	local_irq_enable();
 	return;
 
 softnet_break:

Re: [PATCH] NET: [CORE] Re-enable irqs before pushing pending DMA requests

From: David Miller <davem@davemloft.net>
Date: 2007-06-24 06:09:26

From: Shannon Nelson <redacted>
Date: Thu, 21 Jun 2007 09:34:55 -0700
This moves the local_irq_enable() call in net_rx_action() to before
calling the CONFIG_NET_DMA's dma_async_memcpy_issue_pending() rather
than after.  This shortens the irq disabled window and allows for DMA
drivers that need to do their own irq hold.

Signed-off-by: Shannon Nelson <redacted>
Patch applied, thanks Shannon.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help