[PATCH] [TCP]: Add missing break to TCP option parsing code

Subsystems: networking [general], networking [tcp], the rest

STALE6993d

2 messages, 2 authors, 2007-06-14 · open the first message on its own page

[PATCH] [TCP]: Add missing break to TCP option parsing code

From: Ilpo Järvinen <hidden>
Date: 2007-06-14 09:37:24

This flaw does not affect any behavior (currently).

Signed-off-by: Ilpo Järvinen <redacted>
---
 net/ipv4/tcp_input.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index d506bdc..aaf6f66 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -2936,6 +2936,7 @@ void tcp_parse_options(struct sk_buff *skb, struct tcp_options_received *opt_rx,
 					   opt_rx->sack_ok) {
 						TCP_SKB_CB(skb)->sacked = (ptr - 2) - (unsigned char *)th;
 					}
+					break;
 #ifdef CONFIG_TCP_MD5SIG
 				case TCPOPT_MD5SIG:
 					/*
-- 
1.5.0.6

Re: [PATCH] [TCP]: Add missing break to TCP option parsing code

From: David Miller <davem@davemloft.net>
Date: 2007-06-14 20:01:01

From: "Ilpo_Järvinen" <redacted>
Date: Thu, 14 Jun 2007 12:37:22 +0300 (EEST)
This flaw does not affect any behavior (currently).

Signed-off-by: Ilpo Järvinen <redacted>
Good catch, patch applied.

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help