[PATCH 1/5] cxgb3 - fix skb->dev dereference

Subsystems: networking drivers, the rest

STALE7016d

2 messages, 2 authors, 2007-06-20 · open the first message on its own page

[PATCH 1/5] cxgb3 - fix skb->dev dereference

From: <hidden>
Date: 2007-05-30 17:01:44

From: Divy Le Ray <redacted>

eth_type_trans() now sets skb->dev. 
References to skb->dev should happen after it is called.

Signed-off-by: Divy Le Ray <redacted>
---

 drivers/net/cxgb3/sge.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cxgb3/sge.c b/drivers/net/cxgb3/sge.c
index 3666586..eaa7dac 100644
--- a/drivers/net/cxgb3/sge.c
+++ b/drivers/net/cxgb3/sge.c
@@ -1690,8 +1690,8 @@ static void rx_eth(struct adapter *adap,
 	struct port_info *pi;
 
 	skb_pull(skb, sizeof(*p) + pad);
-	skb->dev->last_rx = jiffies;
 	skb->protocol = eth_type_trans(skb, adap->port[p->iff]);
+	skb->dev->last_rx = jiffies;
 	pi = netdev_priv(skb->dev);
 	if (pi->rx_csum_offload && p->csum_valid && p->csum == 0xffff &&
 	    !p->fragment) {

Re: [PATCH 1/5] cxgb3 - fix skb->dev dereference

From: Jeff Garzik <hidden>
Date: 2007-06-20 23:17:25

divy@chelsio.com wrote:
From: Divy Le Ray <redacted>

eth_type_trans() now sets skb->dev. 
References to skb->dev should happen after it is called.

Signed-off-by: Divy Le Ray <redacted>
---

 drivers/net/cxgb3/sge.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
applied 1-5 to #upstream-fixes (2.6.22)

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help