# Re: \[PATCH 0/4\] spidernet: support for Celleb

- From: Benjamin Herrenschmidt \<benh@kernel.crashing.org\>
- Date: 2007-02-08 00:24:45 
- List: netdev
- Page: https://ratatoskr.run/netdev/2007/02/9415302
- Thread: https://ratatoskr.run/netdev/2007/02/9415219/t.md

```text
On Wed, 2007-02-07 at 17:15 -0500, Jeff Garzik wrote:
> Ishizaki Kou wrote:
> > This is a revised spidernet patch set based on
> > netdev-2.6.git#upstream.
> > 
> > This patch set is merged Jens-san's spidernet patch and works on
> > Toshiba Cell reference set (aka Celleb). 
> > It requires Jens-san's phy patch
> > (http://ozlabs.org/pipermail/linuxppc-dev/2007-February/030987.html).
> 
> I'm unsure of the status of the phy patch, so will put this patchset on 
> hold until that is resolved

PHY patch is mostly Ok except I don't like that "medium" variable Jens
added which isn't used anywhere in sungem_phy. Jens, can you resend a
version without that ? If you need that variable in spidernet itself,
then put it there :-)

Also, the GMII_* constants, are they standard or 54xx specific ? If the
later, then change the name to reflect that.

Once I have the new patch, I'll give it a test on G5 and if it's ok, it
will be good to go for 2.6.21

Cheers,
Ben.
```