[PATCH 10/12]: spidernet: transmit race
From: Linas Vepstas <hidden>
Date: 2007-02-20 22:42:05
Also in:
lkml
From: Linas Vepstas <hidden>
Date: 2007-02-20 22:42:05
Also in:
lkml
Multiple threads performing a transmit can race into the spidernet tx ring cleanup code. This puts the relevant check under a lock. Signed-off-by: Linas Vepstas <redacted> Cc: Jens Osterkamp <redacted> Cc: Kou Ishizaki <redacted> ---- drivers/net/spider_net.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) Index: linux-2.6.20-git16/drivers/net/spider_net.c ===================================================================
--- linux-2.6.20-git16.orig/drivers/net/spider_net.c 2007-02-20 15:02:46.000000000 -0600
+++ linux-2.6.20-git16/drivers/net/spider_net.c 2007-02-20 15:02:48.000000000 -0600@@ -803,8 +803,12 @@ spider_net_release_tx_chain(struct spide unsigned long flags; int status; - while (chain->tail != chain->head) { + while (1) { spin_lock_irqsave(&chain->lock, flags); + if (chain->tail == chain->head) { + spin_unlock_irqrestore(&chain->lock, flags); + return 0; + } descr = chain->tail; hwdescr = descr->hwdescr;