Re: [PATCH -MM] e1000: rewrite hardware initialization code

3 messages, 3 authors, 2007-01-09 · open the first message on its own page

Re: [PATCH -MM] e1000: rewrite hardware initialization code

From: Krzysztof Halasa <khc@pm.waw.pl>
Date: 2007-01-09 19:16:30 

Auke Kok [off-list ref] writes:

 drivers/net/e1000/Makefile            |   19
 drivers/net/e1000/e1000.h             |   95
 drivers/net/e1000/e1000_80003es2lan.c | 1330 +++++
 drivers/net/e1000/e1000_80003es2lan.h |   89
 drivers/net/e1000/e1000_82540.c       |  586 ++
 drivers/net/e1000/e1000_82541.c       | 1164 ++++
 drivers/net/e1000/e1000_82541.h       |   86
 drivers/net/e1000/e1000_82542.c       |  466 ++
 drivers/net/e1000/e1000_82543.c       | 1397 +++++
 drivers/net/e1000/e1000_82543.h       |   45
 drivers/net/e1000/e1000_82571.c       | 1132 ++++
 drivers/net/e1000/e1000_82571.h       |   42
Perhaps the "e1000_" prefix could be dropped as redundant?
-- 
Krzysztof Halasa

Re: [PATCH -MM] e1000: rewrite hardware initialization code

From: Randy Dunlap <hidden>
Date: 2007-01-09 19:26:30 

On Tue, 09 Jan 2007 20:16:27 +0100 Krzysztof Halasa wrote:

Auke Kok [off-list ref] writes:
quoted
 drivers/net/e1000/Makefile            |   19
 drivers/net/e1000/e1000.h             |   95
 drivers/net/e1000/e1000_80003es2lan.c | 1330 +++++
 drivers/net/e1000/e1000_80003es2lan.h |   89
 drivers/net/e1000/e1000_82540.c       |  586 ++
 drivers/net/e1000/e1000_82541.c       | 1164 ++++
 drivers/net/e1000/e1000_82541.h       |   86
 drivers/net/e1000/e1000_82542.c       |  466 ++
 drivers/net/e1000/e1000_82543.c       | 1397 +++++
 drivers/net/e1000/e1000_82543.h       |   45
 drivers/net/e1000/e1000_82571.c       | 1132 ++++
 drivers/net/e1000/e1000_82571.h       |   42
Perhaps the "e1000_" prefix could be dropped as redundant?
-- 
Yes, that suggestion would agree with what Linus told us about
usb file names 7 years ago.  (huh?  that long?)

---
~Randy

Re: [PATCH -MM] e1000: rewrite hardware initialization code

From: Auke Kok <hidden>
Date: 2007-01-09 19:45:52 

Randy Dunlap wrote:
On Tue, 09 Jan 2007 20:16:27 +0100 Krzysztof Halasa wrote:
quoted
Auke Kok [off-list ref] writes:
quoted
 drivers/net/e1000/Makefile            |   19
 drivers/net/e1000/e1000.h             |   95
 drivers/net/e1000/e1000_80003es2lan.c | 1330 +++++
 drivers/net/e1000/e1000_80003es2lan.h |   89
 drivers/net/e1000/e1000_82540.c       |  586 ++
 drivers/net/e1000/e1000_82541.c       | 1164 ++++
 drivers/net/e1000/e1000_82541.h       |   86
 drivers/net/e1000/e1000_82542.c       |  466 ++
 drivers/net/e1000/e1000_82543.c       | 1397 +++++
 drivers/net/e1000/e1000_82543.h       |   45
 drivers/net/e1000/e1000_82571.c       | 1132 ++++
 drivers/net/e1000/e1000_82571.h       |   42
Perhaps the "e1000_" prefix could be dropped as redundant?
-- 
Yes, that suggestion would agree with what Linus told us about
usb file names 7 years ago.  (huh?  that long?)

You'll have to excuse me that I don't remember that anymore, but I'll note the 
suggestion and see what the team thinks.

Thanks,

Auke
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help