[PATCH] net: af_netlink module_put cleanup

STALE7164d

2 messages, 2 authors, 2007-01-02 · open the first message on its own page

[PATCH] net: af_netlink module_put cleanup

From: Mariusz Kozlowski <hidden>
Date: 2007-01-02 12:46:19

Hello,

	This patch removes redundant argument check for module_put().

Signed-off-by: Mariusz Kozlowski <redacted>

 net/netlink/af_netlink.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff -upr linux-2.6.20-rc2-mm1-a/net/netlink/af_netlink.c linux-2.6.20-rc2-mm1-b/net/netlink/af_netlink.c
--- linux-2.6.20-rc2-mm1-a/net/netlink/af_netlink.c	2006-12-24 05:00:32.000000000 +0100
+++ linux-2.6.20-rc2-mm1-b/net/netlink/af_netlink.c	2007-01-02 02:23:02.000000000 +0100
@@ -472,8 +472,7 @@ static int netlink_release(struct socket
 				NETLINK_URELEASE, &n);
 	}	
 
-	if (nlk->module)
-		module_put(nlk->module);
+	module_put(nlk->module);
 
 	netlink_table_grab();
 	if (nlk->flags & NETLINK_KERNEL_SOCKET) {

-- 
Regards,

	Mariusz Kozlowski

Re: [PATCH] net: af_netlink module_put cleanup

From: David Miller <davem@davemloft.net>
Date: 2007-01-02 23:25:12

From: Mariusz Kozlowski <redacted>
Date: Tue, 2 Jan 2007 13:47:37 +0100
Hello,

	This patch removes redundant argument check for module_put().

Signed-off-by: Mariusz Kozlowski <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help