DORMANTno replies REVIEWED: 8 (8M)

1 review trailer.

[PATCH] softmac: Fix missing mutex unlock

From: Larry Finger <hidden>
Date: 2006-12-10 21:40:57
Subsystem: networking [general], the rest · Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

From: Ulrich Kunitz <redacted>

ieee80211softmac_wx_get_genie locks the associnfo mutex at
function exit. This patch fixes it. The patch is against Linus'
tree (commit af1713e0).

Signed-off-by: Ulrich Kunitz <redacted>
Signed-off-by: Michael Buesch <redacted>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Larry Finger <redacted>
---
 net/ieee80211/softmac/ieee80211softmac_wx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

John,

This patch should be applied to wireless-2.6, pushed upstream to 2.6.20.
It will also be sent to -stable.

Larry

diff --git a/net/ieee80211/softmac/ieee80211softmac_wx.c b/net/ieee80211/softmac/ieee80211softmac_wx.c
index 480d72c..fa2f7da 100644
--- a/net/ieee80211/softmac/ieee80211softmac_wx.c
+++ b/net/ieee80211/softmac/ieee80211softmac_wx.c
@@ -463,7 +463,7 @@ ieee80211softmac_wx_get_genie(struct net
 			err = -E2BIG;
 	}
 	spin_unlock_irqrestore(&mac->lock, flags);
-	mutex_lock(&mac->associnfo.mutex);
+	mutex_unlock(&mac->associnfo.mutex);
 
 	return err;
 }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help