[PATCH 2/2] [IrDA] Incorrect TTP header reservation

Subsystems: networking [general], the rest

STALE7199d

2 messages, 2 authors, 2006-12-07 · open the first message on its own page

[PATCH 2/2] [IrDA] Incorrect TTP header reservation

From: Samuel Ortiz <hidden>
Date: 2006-12-07 00:51:20

We must reserve SAR + MAX_HEADER bytes for IrLMP to fit in.

Patch from Jeet Chaudhuri [off-list ref]
Signed-off-by: Samuel Ortiz <redacted>
---
 net/irda/irttp.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/irda/irttp.c b/net/irda/irttp.c
index 252f110..03504f3 100644
--- a/net/irda/irttp.c
+++ b/net/irda/irttp.c
@@ -1100,7 +1100,7 @@ int irttp_connect_request(struct tsap_cb
 			return -ENOMEM;
 
 		/* Reserve space for MUX_CONTROL and LAP header */
-		skb_reserve(tx_skb, TTP_MAX_HEADER);
+		skb_reserve(tx_skb, TTP_MAX_HEADER + TTP_SAR_HEADER);
 	} else {
 		tx_skb = userdata;
 		/*
@@ -1349,7 +1349,7 @@ int irttp_connect_response(struct tsap_c
 			return -ENOMEM;
 
 		/* Reserve space for MUX_CONTROL and LAP header */
-		skb_reserve(tx_skb, TTP_MAX_HEADER);
+		skb_reserve(tx_skb, TTP_MAX_HEADER + TTP_SAR_HEADER);
 	} else {
 		tx_skb = userdata;
 		/*
-- 
1.4.2.3

Re: [PATCH 2/2] [IrDA] Incorrect TTP header reservation

From: David Miller <davem@davemloft.net>
Date: 2006-12-07 04:09:08

From: Samuel Ortiz <redacted>
Date: Thu, 7 Dec 2006 02:51:17 +0200
We must reserve SAR + MAX_HEADER bytes for IrLMP to fit in.

Patch from Jeet Chaudhuri [off-list ref]
Signed-off-by: Samuel Ortiz <redacted>
Also applied.

Are you sending this patch to -stable?  Please do.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help