[PATCH] softmac: fix unbalanced mutex_lock/unlock in ieee80211softmac_wx_set_mlme
From: Larry Finger <hidden>
Date: 2006-12-03 16:40:01
From: Maxime Austruy <maxime-+3Uz/VIkGlWGglJvpFV4uA@public.gmane.org> Routine ieee80211softmac_wx_set_mlme has one return that fails to release a mutex acquired at entry. Signed-off-by: Maxime Austruy <maxime-+3Uz/VIkGlWGglJvpFV4uA@public.gmane.org> Signed-off-by: Larry Finger <redacted> --- John and Chris, This error was introduced in the 2.6.19-rxX series and must be applied to 2.6.19-stable and wireless-2.6. Larry net/ieee80211/softmac/ieee80211softmac_wx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
--- a/net/ieee80211/softmac/ieee80211softmac_wx.c 2006-11-29 13:57:37.000000000 -0800
+++ b/net/ieee80211/softmac/ieee80211softmac_wx.c 2006-12-02 22:58:20.000000000 -0800@@ -495,7 +495,8 @@ ieee80211softmac_wx_set_mlme(struct net_ printk(KERN_DEBUG PFX "wx_set_mlme: we should know the net here...\n"); goto out; } - return ieee80211softmac_deauth_req(mac, net, reason); + err = ieee80211softmac_deauth_req(mac, net, reason); + goto out; case IW_MLME_DISASSOC: ieee80211softmac_send_disassoc_req(mac, reason); mac->associnfo.associated = 0; -
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html