[PATCH] atm/ambassador: fix return code bug
From: Jeff Garzik <hidden>
Date: 2006-10-01 13:33:35
Also in:
lkml
Subsystem:
atm, the rest · Maintainers:
Chas Williams, Linus Torvalds
While auditing a 'may be used uninitialized' warning, I found a minor bug: make_rate() has the standard error code convention -- zero for success, negative errno on error -- but its return type is defined as unsigned. Change the return type to reflect reality. Signed-off-by: Jeff Garzik <redacted>
diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index 4521a24..da599e6 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c@@ -915,8 +915,8 @@ #endif /********** make rate (not quite as much fun as Horizon) **********/ -static unsigned int make_rate (unsigned int rate, rounding r, - u16 * bits, unsigned int * actual) { +static int make_rate (unsigned int rate, rounding r, + u16 * bits, unsigned int * actual) { unsigned char exp = -1; // hush gcc unsigned int man = -1; // hush gcc