DORMANTno replies

[PATCH V2] remove dead code from bcm43xx-softmac

From: Larry Finger <hidden>
Date: 2006-09-04 13:20:08

John,

Please queue the following patch for wireless-2.6. It removes some code that was made obsolete by
the wireless statistics changes of several weeks ago, but was not noticed them.

Thanks,

Larry

=================

This patch removes code that was make obsolete when the wireless statistics in bcm43xx-softmac were
changed, but was overlooked at that time. The value of bcm->stats.link_quality computed here is
never used, so it is removed as well.

Signed-off-by: Larry Finger <redacted>

Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -1549,17 +1549,7 @@ static void handle_irq_noise(struct bcm4
  		else
  			average -= 48;

-/* FIXME: This is wrong, but people want fancy stats. well... */
-bcm->stats.noise = average;
-		if (average > -65)
-			bcm->stats.link_quality = 0;
-		else if (average > -75)
-			bcm->stats.link_quality = 1;
-		else if (average > -85)
-			bcm->stats.link_quality = 2;
-		else
-			bcm->stats.link_quality = 3;
-//		dprintk(KERN_INFO PFX "Link Quality: %u (avg was %d)\n", bcm->stats.link_quality, average);
+		bcm->stats.noise = average;
  drop_calculation:
  		bcm->noisecalc.calculation_running = 0;
  		return;
Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx.h
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx.h
+++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx.h
@@ -688,7 +688,6 @@ struct bcm43xx_noise_calculation {
  };

  struct bcm43xx_stats {
-	u8 link_quality;
  	u8 noise;
  	struct iw_statistics wstats;
  	/* Store the last TX/RX times here for updating the leds. */
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help