DORMANTno replies REVIEWED: 1 (0M)

1 review trailer.

[PATCH 2/7] bonding: Convert delay value from s16 to int

From: Jay Vosburgh <hidden>
Date: 2006-09-01 22:08:26

From: Kenzo Iwami <redacted>

The value of "downdelay/miimon" and "updelay/miimon" are stored in
slave->delay. The type of downdelay, updelay, and miimon are all int.
However, slave->delay is type short, and it is not possible to store the
value of "downdelay/miimon" or "updelay/miimon" in some cases. (For example,
miimon=1 downdelay=32768)

Signed-off-by: Kenzo Iwami <redacted>
Acked-by: Jay Vosburgh <redacted>


diff -urpN linux-2.6.17/drivers/net/bonding/bonding.h
linux-2.6.17_fix/drivers/net/bonding/bonding.h
--- linux-2.6.17/drivers/net/bonding/bonding.h	2006-06-18 10:49:35.000000000 +0900
+++ linux-2.6.17_fix/drivers/net/bonding/bonding.h	2006-06-19 16:52:43.000000000
+0900
@@ -149,7 +149,7 @@ struct slave {
 	struct net_device *dev; /* first - useful for panic debug */
 	struct slave *next;
 	struct slave *prev;
-	s16    delay;
+	int    delay;
 	u32    jiffies;
 	s8     link;    /* one of BOND_LINK_XXXX */
 	s8     state;   /* one of BOND_STATE_XXXX */
-- 
VGER BF report: H 0.391544
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help