d80211: bitfield usage should go

From: Jeff Garzik <hidden>
Date: 2006-08-09 09:07:43

I'm doing an in-depth review of d80211 right now.

One issue that leaps out:  use of bitfields.

1) single-bit signed bitfields are undefined

	int wep_include_iv:1;

2) bitfields in general generate HORRIBLE code.  Just don't use them. 
Compilers often fail to use even the most obvious simplifications.

Use flags and bitwise operators instead, like most other Linux code.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help