[patch 15/17] pppoe: missing result check in __pppoe_xmit()
From: <hidden>
Date: 2006-06-02 03:28:28
From: Florin Malita <redacted> skb_clone() may fail, we should check the result. Coverity CID: 1215. Signed-off-by: Florin Malita <redacted> Cc: "David S. Miller" <davem@davemloft.net> Cc: <redacted> Signed-off-by: Andrew Morton <redacted> --- drivers/net/pppoe.c | 3 +++ 1 file changed, 3 insertions(+) diff -puN drivers/net/pppoe.c~pppoe-missing-result-check-in-__pppoe_xmit drivers/net/pppoe.c
--- devel/drivers/net/pppoe.c~pppoe-missing-result-check-in-__pppoe_xmit 2006-06-01 20:31:50.000000000 -0700
+++ devel-akpm/drivers/net/pppoe.c 2006-06-01 20:31:50.000000000 -0700@@ -861,6 +861,9 @@ static int __pppoe_xmit(struct sock *sk, * give dev_queue_xmit something it can free. */ skb2 = skb_clone(skb, GFP_ATOMIC); + + if (skb2 == NULL) + goto abort; } ph = (struct pppoe_hdr *) skb_push(skb2, sizeof(struct pppoe_hdr));
_