[PATCH] bcm43xx: fix iwmode crash when down
DORMANTno replies
From: Michael Buesch <hidden>
Date: 2006-05-01 20:36:57
From: Michael Buesch <hidden>
Date: 2006-05-01 20:36:57
(Second attempt, now unmangled and with signed-off-by line, uh...) This should go into 2.6.17, as it fixes a user exploitable crash. -- This fixes a crash when iwconfig ethX mode foo is done before ifconfig ethX up or after ifconfig ethX down Signed-off-by: Michael Buesch <redacted> Index: linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_wx.c ===================================================================
--- linux-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_wx.c 2006-04-22 17:47:03.000000000 +0200
+++ linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_wx.c 2006-05-01 22:10:18.000000000 +0200@@ -182,8 +182,11 @@ mode = BCM43xx_INITIAL_IWMODE; bcm43xx_lock_mmio(bcm, flags); - if (bcm->ieee->iw_mode != mode) - bcm43xx_set_iwmode(bcm, mode); + if (bcm->initialized) { + if (bcm->ieee->iw_mode != mode) + bcm43xx_set_iwmode(bcm, mode); + } else + bcm->ieee->iw_mode = mode; bcm43xx_unlock_mmio(bcm, flags); return 0;
--
Greetings Michael.