[2.6 patch] bcm43xx_phy.c: fix a memory leak
DORMANTno replies
From: Adrian Bunk <hidden>
Date: 2006-04-04 18:56:24
Also in:
lkml
This patch fixes a memory leak spotted by the Coverity checker. Signed-off-by: Adrian Bunk <redacted> --- drivers/net/wireless/bcm43xx/bcm43xx_phy.c | 1 + 1 file changed, 1 insertion(+)
--- linux-2.6.17-rc1-mm1-full/drivers/net/wireless/bcm43xx/bcm43xx_phy.c.old 2006-04-04 19:43:04.000000000 +0200
+++ linux-2.6.17-rc1-mm1-full/drivers/net/wireless/bcm43xx/bcm43xx_phy.c 2006-04-04 19:43:38.000000000 +0200@@ -2143,22 +2143,23 @@ int bcm43xx_phy_init_tssi2dbm_table(stru dyn_tssi2dbm = kmalloc(64, GFP_KERNEL); if (dyn_tssi2dbm == NULL) { printk(KERN_ERR PFX "Could not allocate memory" "for tssi2dbm table\n"); return -ENOMEM; } for (idx = 0; idx < 64; idx++) if (bcm43xx_tssi2dbm_entry(dyn_tssi2dbm, idx, pab0, pab1, pab2)) { phy->tssi2dbm = NULL; printk(KERN_ERR PFX "Could not generate " "tssi2dBm table\n"); + kfree(dyn_tssi2dbm); return -ENODEV; } phy->tssi2dbm = dyn_tssi2dbm; phy->dyn_tssi_tbl = 1; } else { /* pabX values not set in SPROM. */ switch (phy->type) { case BCM43xx_PHYTYPE_A: /* APHY needs a generated table. */ phy->tssi2dbm = NULL; printk(KERN_ERR PFX "Could not generate tssi2dBm "