[-mm patch] net/dccp/ipv4.c: make struct dccp_v4_prot static

STALE7500d

2 messages, 2 authors, 2006-02-25 · open the first message on its own page

[-mm patch] net/dccp/ipv4.c: make struct dccp_v4_prot static

From: Adrian Bunk <hidden>
Date: 2006-02-25 13:27:33

On Fri, Feb 24, 2006 at 03:10:02AM -0800, Andrew Morton wrote:
...
Changes since 2.6.16-rc4-mm1:
...
 git-net.patch
...
 git trees.
...

There's no reason for struct dccp_v4_prot being global.


Signed-off-by: Adrian Bunk <redacted>
--- linux-2.6.16-rc4-mm2-full/net/dccp/ipv4.c.old	2006-02-25 04:32:45.000000000 +0100
+++ linux-2.6.16-rc4-mm2-full/net/dccp/ipv4.c	2006-02-25 04:32:53.000000000 +0100
@@ -1022,7 +1022,7 @@
 	.twsk_obj_size	= sizeof(struct inet_timewait_sock),
 };
 
-struct proto dccp_v4_prot = {
+static struct proto dccp_v4_prot = {
 	.name			= "DCCP",
 	.owner			= THIS_MODULE,
 	.close			= dccp_close,

Re: [-mm patch] net/dccp/ipv4.c: make struct dccp_v4_prot static

From: Arnaldo Carvalho de Melo <hidden>
Date: 2006-02-25 14:31:04

On 2/25/06, Adrian Bunk [off-list ref] wrote:
quoted hunk
On Fri, Feb 24, 2006 at 03:10:02AM -0800, Andrew Morton wrote:
quoted
...
Changes since 2.6.16-rc4-mm1:
...
 git-net.patch
...
 git trees.
...

There's no reason for struct dccp_v4_prot being global.


Signed-off-by: Adrian Bunk <redacted>
--- linux-2.6.16-rc4-mm2-full/net/dccp/ipv4.c.old       2006-02-25 04:32:45.000000000 +0100
+++ linux-2.6.16-rc4-mm2-full/net/dccp/ipv4.c   2006-02-25 04:32:53.000000000 +0100
@@ -1022,7 +1022,7 @@
        .twsk_obj_size  = sizeof(struct inet_timewait_sock),
 };

-struct proto dccp_v4_prot = {
+static struct proto dccp_v4_prot = {
        .name                   = "DCCP",
        .owner                  = THIS_MODULE,
        .close                  = dccp_close,
Heck, the last series of patches were exactly to separate ipv4/ipv6 in
DCCP more clearly, how could I forget the cherry on top (sticking this static
in front of dccp_v4_prot)?

Eagle eyes indeed.

Thanks.

- Arnaldo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help