[patch 2.6.14-rc3] epic100: fix counting of work_done in epic_poll

Subsystems: networking drivers, the rest

STALE7593d

2 messages, 2 authors, 2005-10-19 · open the first message on its own page

[patch 2.6.14-rc3] epic100: fix counting of work_done in epic_poll

From: John W. Linville <hidden>
Date: 2005-10-19 01:33:34

work_done is overwritten each time through the rx_action loop in
epic_poll.  This screws-up the NAPI accounting if the loop is executed
more than once.

Signed-off-by: John W. Linville <redacted>
---

 drivers/net/epic100.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/epic100.c b/drivers/net/epic100.c
--- a/drivers/net/epic100.c
+++ b/drivers/net/epic100.c
@@ -1334,7 +1334,7 @@ static void epic_rx_err(struct net_devic
 static int epic_poll(struct net_device *dev, int *budget)
 {
 	struct epic_private *ep = dev->priv;
-	int work_done, orig_budget;
+	int work_done = 0, orig_budget;
 	long ioaddr = dev->base_addr;
 
 	orig_budget = (*budget > dev->quota) ? dev->quota : *budget;
@@ -1343,7 +1343,7 @@ rx_action:
 
 	epic_tx(dev, ep);
 
-	work_done = epic_rx(dev, *budget);
+	work_done += epic_rx(dev, *budget);
 
 	epic_rx_err(dev, ep);
 

Re: [patch 2.6.14-rc3] epic100: fix counting of work_done in epic_poll

From: Jeff Garzik <hidden>
Date: 2005-10-19 02:26:25

applied
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help