[KJ] [PATCH] starfire: free_irq() on error path of netdev_open()
From: Alexey Dobriyan <hidden>
Date: 2005-10-06 22:05:23
Also in:
kernel-janitors
Signed-off-by: Alexey Dobriyan <redacted> --- drivers/net/starfire.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
--- ./drivers/net/starfire.c
+++ ./drivers/net/starfire.c@@ -1091,8 +1091,10 @@ static int netdev_open(struct net_device rx_ring_size = sizeof(struct starfire_rx_desc) * RX_RING_SIZE; np->queue_mem_size = tx_done_q_size + rx_done_q_size + tx_ring_size + rx_ring_size; np->queue_mem = pci_alloc_consistent(np->pci_dev, np->queue_mem_size, &np->queue_mem_dma); - if (np->queue_mem == 0) + if (np->queue_mem == 0) { + free_irq(dev->irq, dev); return -ENOMEM; + } np->tx_done_q = np->queue_mem; np->tx_done_q_dma = np->queue_mem_dma;