Re: [PATCH] net: add driver for the NIC on Cell Blades
From: Arnd Bergmann <arnd@arndb.de>
Date: 2005-06-29 01:01:43
Also in:
lkml
On Dinsdag 28 Juni 2005 15:53, Arjan van de Ven wrote:
quoted
+static void +spider_net_rx_irq_off(struct spider_net_card *card) +{ + u32 regvalue; + unsigned long flags; + + spin_lock_irqsave(&card->intmask_lock, flags); + regvalue = spider_net_read_reg(card, SPIDER_NET_GHIINT0MSK); + regvalue &= ~SPIDER_NET_RXINT; + spider_net_write_reg(card, SPIDER_NET_GHIINT0MSK, regvalue); + spin_unlock_irqrestore(&card->intmask_lock, flags); +}I think you have a PCI posting bug here....
Could you be more specific? My guess would be that the 'sync' in writel takes care of this. Should there be an extra mmiowb() in here or are you referring to some other problem? Arnd <><