Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock
From: Paulo Marques <hidden>
Date: 2005-05-02 14:16:20
Also in:
lkml
From: Paulo Marques <hidden>
Date: 2005-05-02 14:16:20
Also in:
lkml
Mark Broadbent wrote:
The interrupt handling code in the tulip network driver appears to use a non IRQ safe spinlock in an interrupt context. The following patch should correct this.
Huh? Can a network interrupt handler be interrupted by the same interrupt? AFAIK, the spin_lock_irqsave is to disable interruptions so that an interrupt can not happen in the critical section, so that the interrupt handler can not make modifications to shared data. Am I wrong? -- Paulo Marques - www.grupopie.com All that is necessary for the triumph of evil is that good men do nothing. Edmund Burke (1729 - 1797)