[2.6 patch] drivers/net/hamradio/: cleanups

This patch contains the following cleanups:
- mkiss.c: make a needlessly global variable static
- dmascc.c: remove the unused global function dmascc_setup

Signed-off-by: Adrian Bunk <redacted>

---

This patch was already sent on:
- 19 Apr 2005

 drivers/net/hamradio/dmascc.c |   10 ----------
 drivers/net/hamradio/mkiss.c  |    2 +-
 2 files changed, 1 insertion(+), 11 deletions(-)

--- linux-2.6.12-rc2-mm3-full/drivers/net/hamradio/dmascc.c.old	2005-04-19 03:04:36.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/net/hamradio/dmascc.c	2005-04-19 03:04:57.000000000 +0200

@@ -311,16 +311,6 @@
 	}
 }
 
-#ifndef MODULE
-void __init dmascc_setup(char *str, int *ints)
-{
-	int i;
-
-	for (i = 0; i < MAX_NUM_DEVS && i < ints[0]; i++)
-		io[i] = ints[i + 1];
-}
-#endif
-
 static int __init dmascc_init(void)
 {
 	int h, i, j, n;
--- linux-2.6.12-rc2-mm3-full/drivers/net/hamradio/mkiss.c.old	2005-04-19 03:05:20.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/net/hamradio/mkiss.c	2005-04-19 03:05:30.000000000 +0200

@@ -65,7 +65,7 @@
 
 static ax25_ctrl_t **ax25_ctrls;
 
-int ax25_maxdev = AX25_MAXDEV;		/* Can be overridden with insmod! */
+static int ax25_maxdev = AX25_MAXDEV;	/* Can be overridden with insmod! */
 
 static struct tty_ldisc	ax_ldisc;
 

Adrian Bunk wrote:

This patch contains the following cleanups:
- dmascc.c: remove the unused global function dmascc_setup

Better to use it, then remove it.

	Jeff

On Sun, Jun 26, 2005 at 06:26:49PM -0400, Jeff Garzik wrote:

Adrian Bunk wrote:

quoted

This patch contains the following cleanups:
- dmascc.c: remove the unused global function dmascc_setup

Better to use it, then remove it.

Can you give me a hint how it should be used?

Why doesn't dmascc_init together with the MODULE_PARM(io,...) work in 
the non-modular case?

	Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

On Sun, 26 Jun 2005 18:26:49 -0400 Jeff Garzik wrote:

| Adrian Bunk wrote:
| > This patch contains the following cleanups:
| > - dmascc.c: remove the unused global function dmascc_setup
| 
| Better to use it, then remove it.

                    than ??

---
~Randy

randy_dunlap wrote:

On Sun, 26 Jun 2005 18:26:49 -0400 Jeff Garzik wrote:

| Adrian Bunk wrote:
| > This patch contains the following cleanups:
| > - dmascc.c: remove the unused global function dmascc_setup
| 
| Better to use it, then remove it.

                    than ??

Yes.  Use it via __setup() or similar.

	Jeff

On Sun, Jun 26, 2005 at 07:00:13PM -0400, Jeff Garzik wrote:

randy_dunlap wrote:

quoted

On Sun, 26 Jun 2005 18:26:49 -0400 Jeff Garzik wrote:

| Adrian Bunk wrote:
| > This patch contains the following cleanups:
| > - dmascc.c: remove the unused global function dmascc_setup
| 
| Better to use it, then remove it.

                   than ??

Yes.  Use it via __setup() or similar.

Hi Jeff,

I still haven't gotten any answer from you regarding the following 
question:

Can you give me a hint how it should be used?

Why doesn't dmascc_init together with the MODULE_PARM(io,...) work in
the non-modular case?

	Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed