Re: Resend: Re: PATCH: IPSEC acquire in presence of multiple managers
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2005-03-26 19:27:40
On Sat, Mar 26, 2005 at 01:35:31PM -0500, jamal wrote:
int km_query(struct xfrm_state *x, struct xfrm_tmpl *t, struct xfrm_policy *pol)
{
- int err = -EINVAL;
+ int err = -EINVAL, acqret = -EINVAL;BTW, you don't need to initialise acqret here since it's only used inside the loop and is always assigned unconditionally..
+ acqret = km->acquire(x, t, pol, XFRM_POLICY_OUT); + if (!acqret) + err = acqret;
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt