Thread (10 messages) 10 messages, 4 authors, 2005-02-28

Re: [PATCH 1/2] r8169: Jumbo Frames mini-increase

From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2005-02-28 19:32:04

Jon Mason [off-list ref] :
[...]
Applies cleanly to linux-2.6.11-rc4-mm1 and tested on amd64
Thanks, I will test it on x86/sparc64.

[...]
quoted hunk ↗ jump to hunk
@@ -1576,8 +1577,12 @@ rtl8169_hw_start(struct net_device *dev)
 
 	RTL_W8(Cfg9346, Cfg9346_Unlock);
 	RTL_W8(ChipCmd, CmdTxEnb | CmdRxEnb);
-	RTL_W8(EarlyTxThres, EarlyTxThld);
 
+	if (dev->mtu < 7400)
+		RTL_W8(EarlyTxThres, EarlyTxThld);
+	else
+		RTL_W8(EarlyTxThres, LargeSendETT);
+			
1 - Any objection against ternary operator, say:

	RTL_W8(EarlyTxThres, (dev->mtu < 7400) ? EarlyTxThld : LargeSendETT);

2 - patch includes uneeded tabs on the last added (empty) line.

--
Ueimor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help