RE: [PATCH] /driver/net/wan/sbs520

2 messages, 2 authors, 2005-01-10 · open the first message on its own page

RE: [PATCH] /driver/net/wan/sbs520

From: Adam Anthony <hidden>
Date: 2005-01-10 19:51:48

Thank you for the heads up A&M.  I have destroyed the evil [^M]'s, and
updated the package.
http://prdownloads.sourceforge.net/sbs520lnxdrv/sbs520patch.bz2?download
-AA


-----Original Message-----
From: Matthias-Christian Ott [mailto:matthias.christian@tiscali.de] 
Sent: Monday, January 10, 2005 12:26 PM
To: Alexey Dobriyan
Cc: Adam Anthony; netdev@oss.sgi.com; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] /driver/net/wan/sbs520

Alexey Dobriyan wrote:
On Mon, 10 Jan 2005 07:46:52 -0700, Adam Anthony wrote:

 
quoted
With the permission of my employer, SBS Technologies, Inc., I have
released a patch for 2.4 kernels that supports the 520 Series of WAN
adapters.
   
My editor shows ^M at the end of every line of new
Documentation/Configure.help,
quoted hunk
MAINTAINERS (add ~63400 bogus lines!). Please, look at the patch _after_
generating it.

 
quoted
+obj-$(CONFIG_LANMEDIA)		+=		syncppp.o^M
   
 
quoted
+subdir-$(CONFIG_LANMEDIA) += lmc^M
   
Also random ^M's.
--- linux-2.4.28-virgin/drivers/net/wan/sbs520/lnxosl.c
+++ /usr/src/linux-2.4.28/drivers/net/wan/sbs520/lnxosl.c

 
quoted
+// Programming Language:	C^M
+// Target Processor:		Any^M
+// Target Operating System: Linux^M
   
Well, this is pretty obvious to everyone here. :-)

 
quoted
+// This software may be used and distributed according to the terms^M
+// of the GNU General Public License, incorporated herein by reference.^M
   
Stupid question: do you mean GPL version 2 or something else?

Alexey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

 
That's ugly, that are Microsoft line endings.

Matthias-Christian Ott

***This message has been scanned for virus, spam, and undesirable
content.***
***For further information, contact your mail administrator.***

For limitations on the use and distribution of this message, please visit www.sbs.com/emaildisclaimer.

Re: [PATCH] /driver/net/wan/sbs520

From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2005-01-10 20:40:11

Adam Anthony [off-list ref] :
Thank you for the heads up A&M.  I have destroyed the evil [^M]'s, and
updated the package.
http://prdownloads.sourceforge.net/sbs520lnxdrv/sbs520patch.bz2?download
o OsMapPhysToVirt
  -> should be ioremap/pci_iomap()

o OsUnMapVirt
  -> iounmap, etc.

o OsAllocateNonPagedMemory/OsMemcpy/OsStall/OsSleep/OsZeroMem
  -> useless wrappers.

o OsAllocateDeviceMemory
  Yuck, virt_to_bus !
  Please read:
  - linux-2.6.x/Documentation/DMA-mapping.txt
  - linux-2.6.x/Documentation/DMA-API.txt
  drivers/net/*.c provides a lot of good examples for recent PCI
  devices.

o OsReadPciConfiguration
  Please see pci_resource_{start/len} and friends.

At this point, lnxosl.c will be removable and nobody will regret it.

--
Ueimor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help