# Re: \[PATCH/RFC\] Reduce call chain length in netfilter (was: Re: do\_IRQ: stack overflow: 872..)

- From: Martin Josefsson \<hidden\>
- Date: 2005-01-23 16:08:29 
- List: netdev
- Page: https://ratatoskr.run/netdev/2005/01/10748441
- Thread: https://ratatoskr.run/bridge/2005/01/10747758/t.md

```text
On Sun, 2005-01-23 at 13:40 +0100, Bart De Schuymer wrote:

> Hi Martin,

Hi Bart

> > I guess you never testcompiled with CONFIG_NETFILTER_DEBUG set :)
> 
> Oops, no. I was imagining I could code that without error...
> There was another compile error with CONFIG_NETFILTER_DEBUG in the patch
> (skb that should have been (*pskb)) :(

:)

> > > +			if (verdict > NF_MAX_VERDICT) {
> > > +				NFDEBUG("Evil return from %p(%u).\n",
> > > +				        elem->hook, hook);
> > > +				continue;
> > > +			}
> > 
> > Maybe add unlikely() around the test?
> 
> OK. I added another one around another debugging if-statement.

I'm now running a kernel with this patch and everything seems to still
be working.
So unless someone else has something to comment I think this should be
applied.
The decrease in call-depth is important.

-- 
/Martin
```

## Attachments

- [signature.asc](https://ratatoskr.run/netdev/2005/01/10748441/attachment/0) (application/pgp-signature, 189 bytes)