RE: [patch 1/1] net/farsync: add set_current_state() before schedule_timeout()
From: "Kevin Curtis" <kevin.curtis@farsite.co.uk>
Date: 2005-01-12 08:36:06
This looks fine to me. -----Original Message----- From: domen@coderock.org [mailto:domen@coderock.org] Sent: 11 January 2005 23:08 To: kevin.curtis@farsite.co.uk Cc: netdev@oss.sgi.com; domen@coderock.org; nacc@us.ibm.com; janitor@sternwelten.at Subject: [patch 1/1] net/farsync: add set_current_state() before schedule_timeout() Any comments would be appreciated. Description: Insert set_current_state() before schedule_timeout() so the function delays as expected. Without the addition, schedule_timeout() will return immediately. Signed-off-by: Nishanth Aravamudan <redacted> Signed-off-by: Maximilian Attems <redacted> Signed-off-by: Domen Puncer <redacted> --- kj-domen/drivers/net/wan/farsync.c | 1 + 1 files changed, 1 insertion(+) diff -puN drivers/net/wan/farsync.c~set_current_state-drivers_net_wan_farsync drivers/net/wan/farsync.c --- kj/drivers/net/wan/farsync.c~set_current_state-drivers_net_wan_farsync 2005-01-10 18:00:19.000000000 +0100
+++ kj-domen/drivers/net/wan/farsync.c 2005-01-10 18:00:19.000000000
+0100@@ -981,6 +981,7 @@ fst_issue_cmd(struct fst_port_info *port /* Wait for any previous command to complete */ while (mbval > NAK) { spin_unlock_irqrestore(&card->card_lock, flags); + set_current_state(TASK_UNINTERRUPTIBLE); schedule_timeout(1); spin_lock_irqsave(&card->card_lock, flags);
_