Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET

* James Morris (jmorris@redhat.com) wrote:

On Thu, 18 Nov 2004, Alan Cox wrote:

quoted

As to the other stuff I think the only change needed is to check the
queued asynchronous error and report that before going on to the
connected test

How about this?

The other patch is already committed, so relative diff would be needed.

(Also now ignores any supplied address per 
http://www.opengroup.org/onlinepubs/009695399/functions/sendto.html)

Nitpick, but I missed where it said ignore the address.  And it seems
counter intuitive to provide address, only to have it ignored and
delivered elsewhere.

thanks,
-chris

On Thu, 18 Nov 2004, Chris Wright wrote:

quoted

(Also now ignores any supplied address per 
http://www.opengroup.org/onlinepubs/009695399/functions/sendto.html)

Nitpick, but I missed where it said ignore the address.  And it seems
counter intuitive to provide address, only to have it ignored and
delivered elsewhere.

For sendto():
  "If the socket is connection-mode, dest_addr shall be ignored."

For sendmsg():
  "If the socket is connection-mode, the destination address in msghdr 
   shall be ignored."

I agree that it's counter intuitive (and surely an application bug), but
some feedback I've had suggests we follow the spec.


- James
-- 
James Morris
[off-list ref]