RE: [Patch 12/16 2.5] ixgb: replace kmalloc with vmalloc to allocate driver local data structures

Kmalloc resources are more scarce than vmalloc. In this case, there are
systems where allocation of [rt]xdr->buffer_info fails when the
descriptor ring sizes are set to the maximum allowable value (4096) and
kmalloc is used. Using vmalloc solves this issue.

Ganesh.

-----Original Message-----
From: Christian Borntraeger [mailto:linux-kernel@borntraeger.net] 
Sent: Friday, October 15, 2004 9:47 AM
To: Venkatesan, Ganesh
Cc: jgarzik@pobox.com; netdev
Subject: Re: [Patch 12/16 2.5] ixgb: replace kmalloc with vmalloc to
allocate driver local data structures

Ganesh Venkatesan wrote:

- rxdr->buffer_info = kmalloc(size, GFP_KERNEL);

[...]

+ rxdr->buffer_info = vmalloc(size);

What is the rationale for this change?

If I recall correctly, Linus opposes the use of vmalloc if there is no
real 
need.

cheers

Christian