Re: [patch 8/8] prism54/islpci_dev: replace schedule_timeout() with msleep()

From: Margit Schubert-While <hidden>
Date: 2004-09-02 17:30:18

On Thu, 02 Sep 2004, Nishanth scribeth:
A grep of drivers/net/wireless/prism54 for schedule_timeout showed three
occurrences (in 2.6.9-rc1-bk7):
islpci_dev.c:   schedule_timeout(50*HZ/1000);
islpci_dev.c:           remaining = schedule_timeout(HZ);
islpci_mgt.c:           timeleft = schedule_timeout(wait_cycle_jiffies);
The first is removed by my patch.
The second & third are potentially bugs as there is no
set_current_state() preceding the call to schedule_timeout(). As per the
source:
Nope, look a few lines above:
DEFINE_WAIT() and prepare_to_wait().

Margit
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help