Re: [PATCH] Trivial ipv6 fix.

2 messages, 2 authors, 2004-08-03 · open the first message on its own page

Re: [PATCH] Trivial ipv6 fix.

From: YOSHIFUJI Hideaki / 吉藤英明 <hidden>
Date: 2004-08-02 13:59:22

In article [off-list ref] (at Mon, 02 Aug 2004 20:12:08 +1200), Ralph Loader [off-list ref] says:
ipv6_addr_hash doesn't do what it's comment says.  The comment was
probably what was intended, not that it'll make much difference in
practice.
Oops, David, please apply this.
Signed-off-by: Ralph Loader <redacted>
Signed-off-by: Hideaki YOSHIFUJI <redacted>

===== include/net/addrconf.h 1.17 vs edited =====
--- 1.17/include/net/addrconf.h	2004-07-29 02:00:50 +09:00
+++ edited/include/net/addrconf.h	2004-08-02 22:57:38 +09:00
@@ -178,8 +178,8 @@
 	 * This will include the IEEE address token on links that support it.
 	 */
 
-	word = addr->s6_addr[2] ^ addr->s6_addr32[3];
-	word  ^= (word>>16);
+	word = addr->s6_addr32[2] ^ addr->s6_addr32[3];
+	word ^= (word >> 16);
 	word ^= (word >> 8);
 
 	return ((word ^ (word >> 4)) & 0x0f);
-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

Re: [PATCH] Trivial ipv6 fix.

From: David S. Miller <hidden>
Date: 2004-08-03 00:12:12

On Mon, 02 Aug 2004 06:59:40 -0700 (PDT)
YOSHIFUJI Hideaki / $B5HF#1QL@(B [off-list ref] wrote:
In article [off-list ref] (at Mon, 02 Aug 2004 20:12:08 +1200), Ralph Loader [off-list ref] says:
quoted
ipv6_addr_hash doesn't do what it's comment says.  The comment was
probably what was intended, not that it'll make much difference in
practice.
Oops, David, please apply this.
Done, thanks guys.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help