3 messages, 2 authors, 2004-07-04 · open the first message on its own page
From: Christoph Hellwig <hch@infradead.org>
Date: 2004-07-04 18:45:13
Is your patch for vanilla 2.6.7?
Sorry, it's for Linus' current BK tree. I've attached three files that you should be able to just copy over your regular 2.6.7 tree: include/linux/pci_ids.h drivers/net/sk98lin/skge.c drivers/net/sk98lin/h/skdrv2nd.h (all gzipped)
From: Bernd Schubert <hidden>
Date: 2004-07-04 22:01:43
Sorry, it's for Linus' current BK tree. I've attached three files that you should be able to just copy over your regular 2.6.7 tree:
Thanks, this driver compiles fine. [from your other mail]
the previous one) makes it work unless you change the interface name manually, but as Linux explicitly allows that the interface is fundamentally broken and probably should just go away.
Unfortunality we rename all interfaces using ifrename to make sure that the interface names won't change with different kernel versions (we have this problem when we switch between 2.4. and 2.6.). So it is normal that the oops occurs on unloading the modules? Btw, on 22th June I got another skge.c patch from Herbert Xu to fix another oops: http://lkml.org/lkml/2004/6/22/44 This patch applies fine on top of your new versions (with 400 lines offset), maybe this patch should also be included into the current BK tree? Thanks a lot, Bernd
From: Christoph Hellwig <hch@infradead.org>
Date: 2004-07-04 22:04:49
On Mon, Jul 05, 2004 at 12:01:35AM +0200, Bernd Schubert wrote:
[from your other mail]quoted
the previous one) makes it work unless you change the interface name manually, but as Linux explicitly allows that the interface is fundamentally broken and probably should just go away.Unfortunality we rename all interfaces using ifrename to make sure that the interface names won't change with different kernel versions (we have this problem when we switch between 2.4. and 2.6.). So it is normal that the oops occurs on unloading the modules?
Well, the problem is that someone smoked bad crack when designing the sk98lin procfs interface ;-) We should probably just kill it and find a better way to export the information if nessecary. I'll take a look at that.
Btw, on 22th June I got another skge.c patch from Herbert Xu to fix another oops: http://lkml.org/lkml/2004/6/22/44 This patch applies fine on top of your new versions (with 400 lines offset), maybe this patch should also be included into the current BK tree?
Jeff already merged that patch.