3 messages, 2 authors, 2004-06-17 · open the first message on its own page
From: Tomas Szepe <hidden>
Date: 2004-06-16 11:13:41
On Jun-15 2004, Tue, 22:56 -0700 Linus Torvalds [off-list ref] wrote:
Summary of changes from v2.6.7-rc3 to v2.6.7
[snip] 2.6.7's airo.ko (unlike 2.6.6's) won't allow the user to set ESSID via "echo myessid >/proc/driver/aironet/ethX/SSID". Changes like this shouldn't probably be made in the middle of a stable series. -- Tomas Szepe [off-list ref]
From: <hidden>
Date: 2004-06-16 12:18:53
On Wed, Jun 16, 2004 at 01:13:29PM +0200, Tomas Szepe wrote:
On Jun-15 2004, Tue, 22:56 -0700 Linus Torvalds [off-list ref] wrote:quoted
Summary of changes from v2.6.7-rc3 to v2.6.7[snip] 2.6.7's airo.ko (unlike 2.6.6's) won't allow the user to set ESSID via "echo myessid >/proc/driver/aironet/ethX/SSID". Changes like this shouldn't probably be made in the middle of a stable series.
Changes like this are called bugs. The thing is, original variant of function (actually, both read and write) was also buggy and trivially exploitable, so fixing it was needed. Fscking it up was not, obviously. Fix follows; see if it works for you.
--- RC7/drivers/net/wireless/airo.c Mon Jun 7 19:21:27 2004
+++ RC7-current/drivers/net/wireless/airo.c Wed Jun 16 08:11:50 2004@@ -4527,6 +4527,8 @@ len = priv->maxwritelen - pos; if (copy_from_user(priv->wbuffer + pos, buffer, len)) return -EFAULT; + if (pos + len > priv->writelen) + priv->writelen = pos + len; *offset = pos + len; return len; }
From: Tomas Szepe <hidden>
Date: 2004-06-17 06:57:10
On Jun-16 2004, Wed, 13:18 +0100 viro@parcelfarce.linux.theplanet.co.uk [off-list ref] wrote:
quoted
2.6.7's airo.ko (unlike 2.6.6's) won't allow the user to set ESSID via "echo myessid >/proc/driver/aironet/ethX/SSID". Changes like this shouldn't probably be made in the middle of a stable series.Changes like this are called bugs. The thing is, original variant of function (actually, both read and write) was also buggy and trivially exploitable, so fixing it was needed. Fscking it up was not, obviously.
Sure, I just assumed somebody had done this on purpose.
Fix follows; see if it works for you.
Works for me, thanks. -- Tomas Szepe [off-list ref]