[PATCH] remove useless MOD_{INC,DEC}_USE_COUNT

STALE8157d

2 messages, 2 authors, 2004-05-11 · open the first message on its own page

[PATCH] remove useless MOD_{INC,DEC}_USE_COUNT

From: Christoph Hellwig <hch@lst.de>
Date: 2004-05-07 10:43:11 

*grr* - this one slipped in after my last round of audits it seems.


--- 1.15/drivers/net/gt96100eth.c	Mon Apr  5 22:31:23 2004
+++ edited/drivers/net/gt96100eth.c	Mon May  3 13:22:22 2004
@@ -1070,22 +1070,18 @@
 {
 	int retval;
     
-	MOD_INC_USE_COUNT;
-
 	dbg(2, "%s: dev=%p\n", __FUNCTION__, dev);
 
 	// Initialize and startup the GT-96100 ethernet port
 	if ((retval = gt96100_init(dev))) {
 		err("error in gt96100_init\n");
 		free_irq(dev->irq, dev);
-		MOD_DEC_USE_COUNT;
 		return retval;
 	}
 
 	if ((retval = request_irq(dev->irq, &gt96100_interrupt,
 				  SA_SHIRQ, dev->name, dev))) {
 		err("unable to get IRQ %d\n", dev->irq);
-		MOD_DEC_USE_COUNT;
 		return retval;
 	}
 	
@@ -1106,8 +1102,6 @@
 	}
 
 	free_irq(dev->irq, dev);
-    
-	MOD_DEC_USE_COUNT;
 	return 0;
 }

Re: [PATCH] remove useless MOD_{INC,DEC}_USE_COUNT

From: Jeff Garzik <hidden>
Date: 2004-05-11 07:07:44 

Christoph Hellwig wrote:
quoted hunk
*grr* - this one slipped in after my last round of audits it seems.


--- 1.15/drivers/net/gt96100eth.c	Mon Apr  5 22:31:23 2004
+++ edited/drivers/net/gt96100eth.c	Mon May  3 13:22:22 2004

applied
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help