DORMANTno replies

[PATCH] 2.6.3 - incorrect handling of the status code from skge_probe

From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2004-02-20 22:50:40

skge_probe() can return -ENODEV as well as number of detected adapters.


 drivers/net/sk98lin/skge.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff -puN drivers/net/sk98lin/skge.c~sk98-bad-test drivers/net/sk98lin/skge.c
--- linux-2.6.3/drivers/net/sk98lin/skge.c~sk98-bad-test	2004-02-20 23:39:41.000000000 +0100
+++ linux-2.6.3-fr/drivers/net/sk98lin/skge.c	2004-02-20 23:43:59.000000000 +0100
@@ -779,9 +779,10 @@ static int __init skge_init_module(void)
 
 	cards = skge_probe();
 	if (cards == 0) {
-		printk("sk98lin: No adapter found.\n");
+		printk(KERN_INFO "sk98lin: No adapter found.\n");
+		cards = -ENODEV;
 	}
-	return cards ? 0 : -ENODEV;
+	return (cards > 0 ) ? 0 : cards;
 } /* skge_init_module */
 
 
_
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help