Re: Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook

On Mon, 16 Feb 2004, Mika Penttilä wrote:

quoted

James Morris wrote:

quoted

No, it's not needed by all callers, and is just a does-one-thing helper 
function.

It is needed for cloned skbs, so check for this should go in 
skb_checksum_help().

No, there is no need to bloat a simple helper function out with this 
(and then need to handle OOM internally etc.), and it is not appropriate 
for all callers.

- James

Copy is always required whenever skb_cloned() is true. skb_checksum_help() modifies the shared protocol checksum but leaves ip_summed to CHECKSUM_HW in other clones.

--Mika