RE: Update FarSync WAN driver in 2.4.25

Hi,
	Please find attached a revised patch file which I believe
addresses the comments that you and Francois Romieu made.

	I have changed the bottom half to use schedule_task, although I
can see a marked degradation in performance.  Can you tell me if it is
possible to still queue my tasks on the Immediate queue, so that they
run as soon as the interrupt is complete.  It seems to me that the
task_queue and tasklets are not as efficient.


Kind regards

Kevin



-----Original Message-----
From: Jeff Garzik [mailto:jgarzik@pobox.com] 
Sent: 04 February 2004 21:18
To: Kevin Curtis
Cc: 'netdev@oss.sgi.com'; 'davem@redhat.com'
Subject: Re: Update FarSync WAN driver in 2.4.25


Comments:

* please use standard indentation (one tab)

* please use constants per the include/linux/pci_ids.h standard, rather 
than defining your own.

* please use standard include/linux/pci.h constants, rather than 
defining your own (PCIILR, etc.)

* further, obtain interrupt from struct pci_dev::irq after calling 
pci_enable_device(); do not obtain directly via pci_read_config_xxx()

* fst_process_rx_status() could result in flooding the log

* use pci_set_master() to enable bus-mastering

* bottom halves are deprecated.  do not add new code using mark_bh() and

friends.  Use tasklets or schedule_task().

* use pci_set_dma_mask() rather than pci_dma_supported()

* use pci_request_regions() rather than request_region()